Skip to content

refactor: create check.go, use flagrun and seferio - #15

Merged
kazeburo merged 3 commits into
masterfrom
feat/refactor-and-flagrun
Aug 16, 2026
Merged

refactor: create check.go, use flagrun and seferio#15
kazeburo merged 3 commits into
masterfrom
feat/refactor-and-flagrun

Conversation

@kazeburo

@kazeburo kazeburo commented Aug 16, 2026

Copy link
Copy Markdown
Member

PR Type

Enhancement, Bug fix


Description

  • Extracts command checking into check.go

  • Replaces custom CLI parsing with flagrun

  • Uses safer file access and argument validation

  • Updates tests and dependencies for refactoring


Diagram Walkthrough

flowchart LR
  CLI["flagrun CLI"] --> RUN["Opt.Run"]
  RUN --> CHECK["Opt.check"]
  CHECK --> EXEC["Execute command"]
  CHECK --> SAFE["Read stored results via saferio"]
  CHECK --> RESULT["Return checker status"]
Loading

File Walkthrough

Relevant files
Enhancement
2 files
check.go
Extract command checking implementation                                   
+97/-0   
main.go
Integrate flagrun command execution                                           
+7/-139 
Tests
1 files
check_test.go
Update tests for check method                                                       
+8/-8     
Bug fix
1 files
diff.go
Harden stored result file reads                                                   
+16/-14 
Miscellaneous
2 files
open_unix.go
Remove custom Unix file opener                                                     
+0/-15   
open_windows.go
Remove custom Windows file opener                                               
+0/-12   
Configuration changes
1 files
Makefile
Simplify build metadata configuration                                       
+2/-3     
Dependencies
1 files
go.mod
Add flagrun and saferio dependencies                                         
+2/-0     

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 7abe5da)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

Comment thread main.go
Comment thread check.go Outdated
Comment thread main.go
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit bdb68fc

Comment thread check.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 7abe5da

Comment thread check.go
@kazeburo
kazeburo merged commit dbb22a9 into master Aug 16, 2026
3 checks passed
@kazeburo
kazeburo deleted the feat/refactor-and-flagrun branch August 16, 2026 14:15
@github-actions github-actions Bot mentioned this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant