Skip to content

Feat/check and ship - #14

Merged
kazeburo merged 2 commits into
mainfrom
feat/check-and-ship
Aug 16, 2026
Merged

Feat/check and ship#14
kazeburo merged 2 commits into
mainfrom
feat/check-and-ship

Conversation

@kazeburo

@kazeburo kazeburo commented Aug 16, 2026

Copy link
Copy Markdown
Member

PR Type

Bug fix, Tests


Description

  • Default unnamed checker output to executable basename

  • Preserve valid checker status-to-exit-code mapping

  • Update checker tests for prefixed default name


Diagram Walkthrough

flowchart LR
  Checker["Checker result without name"]
  DefaultName["Executable basename"]
  Output["Formatted checker output"]
  Checker -- "has empty name" --> DefaultName
  DefaultName -- "sets checker name" --> Output
Loading

File Walkthrough

Relevant files
Bug fix
flagrun.go
Default unnamed checker output names                                         

flagrun.go

  • Set an empty checker Name to filepath.Base(os.Args[0]).
  • Ensure checker output includes a default executable-derived name.
  • Normalize indentation in status return cases.
+8/-4     
Tests
flagrun_check_test.go
Test default checker name formatting                                         

flagrun_check_test.go

  • Update expected checker message to include flagrun.test.
  • Verify unnamed checkers receive the test executable basename.
+1/-1     

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@kazeburo
kazeburo merged commit 4abaf8a into main Aug 16, 2026
3 checks passed
@kazeburo
kazeburo deleted the feat/check-and-ship branch August 16, 2026 03:31
@github-actions github-actions Bot mentioned this pull request Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant