refactor: rename timeOnPage to activeTimeOnPage in selectPlacements page_events - #110
Merged
Merged
Conversation
…age_events The value is derived from the diff of consecutive activeTimeOnSite readings, so activeTimeOnPage is both consistent with the neighbouring activeTimeOnSite field and more accurate about what it measures.
jamesnrokt
approved these changes
Aug 5, 2026
rmi22186
approved these changes
Aug 5, 2026
Collaborator
|
updated the merge branch into development. otherwise lgtm |
Collaborator
|
🎉 This PR is included in version 1.30.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the recently-added
timeOnPagefield toactiveTimeOnPagein thepage_eventspayload surfaced in theselectPlacementscall.The value is derived from the diff of consecutive
activeTimeOnSitereadings, soactiveTimeOnPage:activeTimeOnSitefield, andChanges
src/Rokt-Kit.ts—PageEvent.timeOnPage→activeTimeOnPage(interface +buildPageEventsassignment)test/src/tests.spec.ts— updated all references andit(...)descriptionsVerification
npm run lintnpm run buildnpm run test— 228/228 passing🤖 Generated with Claude Code