Aqw echoed dev#141
Merged
Merged
Conversation
Changed:
- frontend/src/app/components/echo-header/echo-header.component.scss: explicitly sets sticky
positioning, top: 0, and a stable z-index.
- frontend/src/app/pages/home/home.component.scss: bounds the main shell to the viewport and keeps
scrolling inside the content region.
Verification:
- cmd /c npm run build passed.
- Existing Sass deprecation warnings remain unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progress width now uses an explicit CSS value like 42% instead of Angular’s percent suffix
binding.
Progress normalization now handles both 42 and fractional 0.42 values correctly.
Updated both /learn progress bars and /learn/courses/:courseId course progress.
Added regression tests for rendered bar width and aria-valuenow.
Verification:
Motivation
Why is this change needed?
Type of Change
Test Plan
List the checks you ran.
If you could not run a check, explain why:
Screenshots
Add screenshots for visible UI changes.
Accessibility Check
Describe any accessibility impact, including keyboard, contrast, labels, readable text, and mobile layout where relevant.
Community or Curriculum Impact
Does this affect educator review, historical accuracy, source quality, learner experience, community language, or contribution flow?
Notes
Anything maintainers should know?