Fix/max concurrent transcodes#12
Open
negativeeddy wants to merge 2 commits into
Open
Conversation
added 2 commits
July 16, 2026 14:39
RunStreamingAsync previously threw InvalidOperationException on any non-zero exit code, discarding MakeMKV's rich status codes (253=no disc, 254=bad key, etc.) and creating an inconsistent API with RunAsync (which returns the exit code in CliResult). Changes: - ICliProcessRunner signature: IAsyncEnumerable<string> → IAsyncEnumerable<(string? Line, int? ExitCode)> - CliProcessRunner: yields (line, null) for stdout lines, then (null, exitCode) as final sentinel — same pattern as RunStreamingAllAsync - MakeMkvService 3 call sites: destructure tuple, log warning on non-zero exit instead of crashing - Tests: ToAsyncStream helper updated to yield tuple+sentinel; mock defaults updated 0 build warnings, 0 regressions in tests.
…n every acquire Previously the limiter read the setting once at construction via IOptions<ArmSettings> and created a fixed-size SemaphoreSlim. Changes made via the Settings UI (persisted to the DB RipperSettings table) were never picked up without a restart. Replaced SemaphoreSlim with a dynamic count-and-queue gate that calls SettingsHelper.GetEffectiveSettingsAsync on every AcquireAsync, so UI changes take effect immediately. Cancelled waiters are skipped in the release loop. Limit <= 0 still means unlimited (noop lease).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.