Ignore spent funding cell(s) in channel gossip message - #1489
Ignore spent funding cell(s) in channel gossip message #1489bolajahmad wants to merge 3 commits into
Conversation
Security ReviewResult: No reportable security findings in the intended change. Validation:
Notes:
|
|
@bolajahmad we added I think we can use this new field to improve the existing live cell checking code. |
If I understand correctly and based on the fixes I made, the new |
9575f78 to
492017a
Compare
Closes #530
Description
Currently, during
ChannelAnnouncement, the funding TX is fetched[using get_transaction](https://github.com/nervosnetwork/fiber/blob/develop/crates/fiber-lib/src/ckb/client.rs#L220C4-L227C6).This approach only checks that the
Funding Outpointwas Committed. But a Committed Outpoint does not guarantee availability of the Cell.This PR adds that layer of security.
Tests
cargo fmt --all -- --checkcargo clippy -p fnn --features rocksdb --all-targets -- -D warningsgit diff --cached --check