Add the debug-bundle upload destination to the Clients settings - #800
riccardomanfrin wants to merge 2 commits into
Conversation
A debug bundle carries peer logs, routes, DNS and firewall state, and until now every client path that uploads one without a human picking a destination sent it to the service NetBird runs, with no way for a self-hosted operator to point it elsewhere. netbirdio/netbird publishes the destination to peers from the account settings; this exposes that setting. Empty keeps the current behaviour for cloud accounts and, for a self-hosted deployment, makes the peers keep the bundle locally instead. The URL is validated as https-with-host on the client too, matching what the API accepts: the peer fetches an upload URL from this endpoint and then PUTs the bundle to whatever comes back, so a plaintext hop would expose both.
The client no longer keeps the bundle on the peer when a self-hosted deployment publishes no destination: netbirdio/netbird now falls back to the upload service NetBird runs for every deployment, so the field's help text described behaviour that is not there.
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe client settings now support a configurable debug bundle upload URL. The setting is typed in account data, validated as HTTPS, included in save operations, and exposed through a permission-aware input field. ChangesDebug bundle upload settings
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The debug bundle upload setting validates HTTPS destinations, preserves empty-value fallback behavior, and is persisted through the settings flow. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit set a URL bright, Comment |
2 participants
Exposes the
debug_bundle_upload_urlaccount setting added in netbirdio/netbird#7514 as aDebug Bundle Uploadfield under Settings > Clients.A debug bundle carries peer logs, routes, DNS and firewall state, so the destination decides whose infrastructure that data lands on. Until now every client path that uploaded one without a human picking a destination sent it to the service NetBird runs, with no way for a self-hosted operator to point it elsewhere.
Empty keeps the current behaviour — peers upload to NetBird's service — so nothing changes for an account that leaves it alone. The URL is validated as https-with-host on the client too, matching what the API accepts: the peer fetches an upload URL from this endpoint and then PUTs the bundle to whatever comes back, so a plaintext hop would expose both.
Docs: netbirdio/docs#971.
Summary by CodeRabbit