[client] Backport RPM metadata required for Red Hat software certification to release-0.79 - #7573
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="release_files/netbird.sysconfig">
<violation number="1" location="release_files/netbird.sysconfig:8">
P1: When an RPM user enables these `NB_*` settings, the client service ignores them because this file is installed at `/etc/sysconfig/netbird` but `netbird@.service` reads `/etc/default/netbird`. Make the service load the RPM config path, or install this file at the path the service actually reads.</violation>
</file>
<file name="release_files/rpm-changelog.sh">
<violation number="1" location="release_files/rpm-changelog.sh:13">
P1: On a fresh checkout, the release workflow does not create chglog's required `.chglog.yml` before running `chglog init`, so changelog generation can fail and block all RPM releases. Create the default chglog configuration before initializing the changelog.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| # Red Hat Enterprise Linux 9 ships the in-kernel WireGuard module as a | ||
| # Technology Preview and taints the kernel when it loads. For a fully | ||
| # supported RHEL 9 configuration run the client with userspace WireGuard: | ||
| #NB_WG_KERNEL_DISABLED=true |
There was a problem hiding this comment.
P1: When an RPM user enables these NB_* settings, the client service ignores them because this file is installed at /etc/sysconfig/netbird but netbird@.service reads /etc/default/netbird. Make the service load the RPM config path, or install this file at the path the service actually reads.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At release_files/netbird.sysconfig, line 8:
<comment>When an RPM user enables these `NB_*` settings, the client service ignores them because this file is installed at `/etc/sysconfig/netbird` but `netbird@.service` reads `/etc/default/netbird`. Make the service load the RPM config path, or install this file at the path the service actually reads.</comment>
<file context>
@@ -0,0 +1,14 @@
+# Red Hat Enterprise Linux 9 ships the in-kernel WireGuard module as a
+# Technology Preview and taints the kernel when it loads. For a fully
+# supported RHEL 9 configuration run the client with userspace WireGuard:
+#NB_WG_KERNEL_DISABLED=true
+#
+# Self-hosted management server:
</file context>
|
|
||
| set -eu | ||
|
|
||
| go tool chglog init |
There was a problem hiding this comment.
P1: On a fresh checkout, the release workflow does not create chglog's required .chglog.yml before running chglog init, so changelog generation can fail and block all RPM releases. Create the default chglog configuration before initializing the changelog.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At release_files/rpm-changelog.sh, line 13:
<comment>On a fresh checkout, the release workflow does not create chglog's required `.chglog.yml` before running `chglog init`, so changelog generation can fail and block all RPM releases. Create the default chglog configuration before initializing the changelog.</comment>
<file context>
@@ -0,0 +1,110 @@
+
+set -eu
+
+go tool chglog init
+
+python3 - changelog.yml <<'PYEOF'
</file context>
| go tool chglog init | |
| go tool chglog config | |
| go tool chglog init |
Release artifactsBuilt for PR head
GHCR images (amd64)
This comment is updated by the Release workflow. Artifact links expire according to the workflow retention policy. |
dce2e5b to
7b9d8ed
Compare
…cation (#7562) Declare the runtime dependencies, generate the changelog from git tags with chglog at release time, and ship LICENSE, README.md and an example /etc/sysconfig/netbird as %license, %doc and %config(noreplace). The unit generated by "netbird service install" already reads that path via EnvironmentFile, so post_install.sh is unchanged.
7b9d8ed to
2e551da
Compare
|
2 participants
Describe your changes
Backport of #7562 to
release-0.79. It is a clean cherry-pick of the squash commit 85a3913 with no conflicts.The RPM ships only /usr/bin/netbird, with no Requires, no changelog and no config or doc files, which fails three subtests of the RHEL 9 software certification RPM test. This declares the runtime dependencies, generates the changelog from git tags with chglog at release time, and ships LICENSE, README.md and an example /etc/sysconfig/netbird as %license, %doc and %config(noreplace).
Issue ticket number and link
Original PR: #7562
Stack
Checklist
Documentation
Select exactly one:
Packaging metadata only, same as the original PR; no user-facing behavior change.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__