Expose index reconciliation and require explicit search synchronization - #8
Merged
Conversation
…ading attachment ... SDD-Mutation: entry-20260905-120907-s-cpt-ck5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR exposes search-index reconciliation through the public application runtime and makes search synchronization an explicit host policy.
Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking performance and availability concern in the SearchSyncNone path.
Synchronization scope and reconciliation behavior are coherent and well tested; the remaining concern is that no-sync vector searches still read every attachment before querying an already-warm index.
Files Needing Attention: pkg/application/vector_search.go
Important Files Changed
Comments Outside Diff (1)
pkg/application/vector_search.go, line 38-40 (link)SearchSyncNoneskips index reconciliation, but this call still computes hashes for every current entry before querying the existing index. That process reads every attachment in full, so searches over a warm index still incur graph-wide attachment I/O, and one unavailable attachment prevents the search from reaching the index. Avoid the full attachment scan in the no-sync path, such as by computing freshness information only for returned candidates.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Keep API documentation beside the implem..." | Re-trigger Greptile