You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
https://www.python.org/dev/peps/pep-0420/ says we should prefer not to have init.py. The only information in it is copy-pasted to setup.py (which is the proper place for it, IMO).
https://www.python.org/dev/peps/pep-0420/ says we should prefer not to have init.py. The only information in it is copy-pasted to setup.py (which is the proper place for it, IMO).
I wasn't aware of this PEP. __init__.py is there to make python treat the changelog directory as a package. If you remove it the current installation using setuptools will not work (see line below in setup.py):
Also the __version__ string is there so you can query the package's version as so:
[drulex@gentoo-p53 changelog] [master] $ python
Python 3.7.10 (default, Apr 13 2021, 09:35:06)
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import changelog
>>> changelog.__version__
'1.1.0'
TBH I haven't read the full PEP, this is just how I usually structure my python projects. It allows easy testing with python -m when I don't write setup.py files and makes is easy to extend and add other submodules to the package. Please educate me if there is a better way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.python.org/dev/peps/pep-0420/ says we should prefer not to have init.py. The only information in it is copy-pasted to setup.py (which is the proper place for it, IMO).
And https://pypi.org/project/changelog-neuropoly/ is currently blank:
so this just fixes that up too.