Skip to content

Add prefill decode endpoint mode - #251

Draft
Levi080513 wants to merge 6 commits into
mainfrom
feat-pd-same-host-phase1
Draft

Levi080513 wants to merge 6 commits into
mainfrom
feat-pd-same-host-phase1

Conversation

@Levi080513

@Levi080513 Levi080513 commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Standard and Prefill / Decode deployment modes for endpoint create/edit flows.
  • Add P/D role tabs for Prefill and Decode replicas, resources, environment variables, and engine args.
  • Keep Model Settings and Engine Settings as standalone sections, and place endpoint Replica Settings after Engine Settings for both Standard and P/D modes.
  • Normalize P/D submit payloads to strategy pd, same-host role placement, spec.replicas.num, and role-level replicas/resources/env/variables, while stripping P/D-only fields from standard payloads.
  • Remove KV Settings from the phase 1 UI and payload.
  • Show endpoint status.replicas[] as the only ReplicaStatus list in the Status tooltip, without role summary.
  • Update endpoint types, locales, i18n tracking, and focused unit coverage.

Tests

  • yarn vitest run src/domains/endpoint/hooks/use-endpoint-form.test.tsx
  • yarn vitest run src/domains/endpoint/components/EndpointStatus.test.tsx src/domains/endpoint/hooks/use-endpoint-form.test.tsx src/domains/endpoint/lib/endpoint-form-helpers.test.ts
  • yarn test
  • yarn build
  • yarn biome lint src/domains/endpoint/hooks/use-endpoint-form.tsx src/domains/endpoint/hooks/use-endpoint-form.test.tsx src/locales/en-US.json
  • yarn biome lint src/domains/endpoint/components/EndpointStatus.tsx src/domains/endpoint/components/EndpointStatus.test.tsx src/foundation/components/BaseStatus.tsx src/domains/endpoint/types.ts src/locales/en-US.json
  • node tools/i18n-tracker.cjs
  • node tools/check-i18n-keys.cjs
  • curl -I --max-time 5 http://127.0.0.1:5174/

Notes

  • Live Neutree E2E/TestRail validation was not run in this session because no live environment was configured. Please run the endpoint create-form E2E flow against a deployed control plane before marking ready.
  • Browser automation was unavailable in the latest session; local dev server load was verified by HTTP 200 from http://127.0.0.1:5174/.

Add endpoint create/edit form support for standard versus prefill/decode deployment mode, including role-specific resources, KV transfer settings, and same-host P/D submit normalization.

Cover the new payload transforms, validation, form visibility, and endpoint e2e form expectations.
@codecov-commenter

codecov-commenter commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.89163% with 53 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/domains/endpoint/hooks/use-endpoint-form.tsx 59.20% 44 Missing and 7 partials ⚠️
src/domains/endpoint/components/EndpointStatus.tsx 95.45% 1 Missing ⚠️
src/domains/endpoint/components/ResourcesCard.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants