Skip to content

fix: support human-readable engine argument values - #401

Open
ZeroLiu2018 wants to merge 1 commit into
mainfrom
fix/kv-cache-memory-bytes-format
Open

ZeroLiu2018 wants to merge 1 commit into
mainfrom
fix/kv-cache-memory-bytes-format

Conversation

@ZeroLiu2018

@ZeroLiu2018 ZeroLiu2018 commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • Support the backend's integer/string schema for kv_cache_memory_bytes, so users can enter and retain human-readable values such as 8G.
  • Render union-typed values as text inputs, preserve their string form, and validate schema patterns before saving.
  • Companion backend change: fix: normalize vLLM KV cache size arguments neutree#605.

Test plan

  • GitHub Actions test workflow (lint, typecheck, i18n checks, and unit tests)

@ZeroLiu2018
ZeroLiu2018 marked this pull request as draft August 27, 2026 05:17
@ZeroLiu2018
ZeroLiu2018 force-pushed the fix/kv-cache-memory-bytes-format branch 2 times, most recently from 6c1d322 to 0d7414f Compare September 1, 2026 03:05
@ZeroLiu2018
ZeroLiu2018 force-pushed the fix/kv-cache-memory-bytes-format branch from 0d7414f to 68ceca2 Compare September 1, 2026 03:07
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/foundation/components/VariablesInput.tsx 44.44% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ZeroLiu2018
ZeroLiu2018 marked this pull request as ready for review September 1, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants