fix: support human-readable engine argument values - #401
Open
ZeroLiu2018 wants to merge 1 commit into
Open
ZeroLiu2018 wants to merge 1 commit into
ZeroLiu2018 wants to merge 1 commit into
Conversation
ZeroLiu2018
marked this pull request as draft
August 27, 2026 05:17
ZeroLiu2018
force-pushed
the
fix/kv-cache-memory-bytes-format
branch
2 times, most recently
from
September 1, 2026 03:05
6c1d322 to
0d7414f
Compare
ZeroLiu2018
force-pushed
the
fix/kv-cache-memory-bytes-format
branch
from
September 1, 2026 03:07
0d7414f to
68ceca2
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1 task
ZeroLiu2018
marked this pull request as ready for review
September 1, 2026 07:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kv_cache_memory_bytes, so users can enter and retain human-readable values such as8G.Test plan
testworkflow (lint, typecheck, i18n checks, and unit tests)