fix(chat): stop loading indicator from shifting chat content - #6476
Open
mahibi wants to merge 1 commit into
Open
fix(chat): stop loading indicator from shifting chat content#6476mahibi wants to merge 1 commit into
mahibi wants to merge 1 commit into
Conversation
The loading indicator was rendered as an in-flow sibling of the toolbar. Toggling it changed the toolbar's measured height, which shifted the message list below it (sized via layout_weight) — most noticeable when there weren't enough messages to scroll. Render it as an overlay on top of the toolbar instead, so it no longer occupies layout space or affects the toolbar's height. Assisted-by: Claude Code 2.1.199:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/31282123239/artifacts/9028806055 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loading indicator was rendered as an in-flow sibling of the
toolbar. Toggling it changed the toolbar's measured height, which
shifted the message list below it (sized via layout_weight) —
most noticeable when there weren't enough messages to scroll.
Render it as an overlay on top of the toolbar instead, so it no
longer occupies layout space or affects the toolbar's height.
Assisted-by: Claude Code 2.1.199:claude-sonnet-5
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)