Remove the unpublishable npm package and other dead files#66
Conversation
npm/ was a complete distribution package (bin shim plus a postinstall that downloads the native binary) for a name npm refuses: the unscoped `podcli` is blocked as too similar to `pod-cli`, as RELEASE.md already records. Nothing built or published it, no postinstall referenced its install.js, and it sat at version 2.0.0 while the project shipped 2.4.1. Its README documented `npm i -g podcli` as the install method, so the one thing it did reliably was mislead anyone who opened the repo. The root package.json served as a second dead npm identity for the same name, with `bin` pointing at the legacy ./podcli bash wrapper. It is the TypeScript, Vite, and Remotion dev manifest, and now the version source of truth, so it stays; the bin entry is gone and it is marked private. Also removed: - out/product-shots/ (3.8M of renders referenced by nothing) - podcli and podcli.cmd, pre-native-CLI wrappers; podcli.cmd had zero references and ./podcli was reachable only through the bin entry above .gitignore covered output/ but not out/, which is how the product shots landed in git. Both are ignored now. Installers, setup.sh, and setup.ps1 are untouched: they are the real install and dev-env paths.
|
Warning Review limit reached
Next review available in: 15 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Why
npm/can't worknpm/is a complete distribution package — abin/podcli.jsshim plus apostinstallthat downloads the native binary — for a name npm refuses.RELEASE.md:13already records it:It's dead, not dormant:
postinstallanywhere references itsscripts/install.js."version": "2.0.0"while the project ships2.4.1. It never entered the version-sync path.npm/README.mddocumentsnpm i -g podclias the install method, so the one thing it did reliably was mislead anyone who opened the repo.Removed
npm/out/product-shots/podcli.cmdpodcli(bash wrapper)binentry belowRoot
package.jsonIt was a second dead npm identity for the same blocked name, with
binpointing at the legacy./podcliwrapper. The file itself stays — it's the TypeScript/Vite/Remotion dev manifest and now the version source of truth — but thebinentry is gone and it's markedprivate..gitignoreoutput/was ignored,out/was not. That's how 3.8M of product shots got committed. Both are ignored now. Verifiedscripts/build-studio.shwrites todist/studio, notout/, so nothing legitimate is newly ignored.Kept
install.sh/install.ps1/install.cmd(the real installers) andsetup.sh/setup.ps1(the documented dev-env setup, referenced by README and CONTRIBUTING).Verification
go test ./...,tsc --noEmit, and 61 vitest tests pass.gen-version.shstill reads2.4.1frompackage.jsonafter theprivateaddition, andbackend/version.pystill resolvesVERSION = 2.4.1.Noted, not changed
sync.shexcludesres10...caffemodelanddeploy.prototxtfrom the embed but notyamnet.onnx, so the 15M laughter model is compiled into every launcher on every platform — most of the 22M binary (confirmed: 646yamnetstring hits in the shippedpodcli-darwin-arm64). That's inconsistent with Whisper models, whichEnsureModeldownloads on demand, but embedding does make highlights work offline with zero provisioning. Left alone as a tradeoff to decide separately.