feat(git-node): add git node benchmark#1114
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 62.43% 63.06% +0.63%
==========================================
Files 48 50 +2
Lines 7882 8288 +406
==========================================
+ Hits 4921 5227 +306
- Misses 2961 3061 +100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| const postComment = await cli.prompt( | ||
| 'Should the workflow post the results as a comment on the PR?', | ||
| { defaultAnswer: sameRepo }); |
There was a problem hiding this comment.
This assumes that nodejs/node#64395 will land, I would need to remove it if it doesn't
|
In the last few days we have added a GH workflow for benchmark (which this PR is using) but also one for stress runs. Since these are not Jenkins maybe these don't belong to ncu-ci, but do we want to group all potential GH workflows into a group of commands? Or do we not care about the Jenkins/GH distinction and put these all under I'm not saying we need to add the other workflows now, just asking/thinking about whether we need a pattern of where this (and potential other) commands go. |
|
I agree it would feel weird on |
This is what I was thinking of, but it's more of a suggestion and not a blocking issue for me. |
Add a tool to help spawning GHA benchmark from the CLI. Here's the output from my test run:
N.B.: the tests have been vibe-coded, part of the implementation has also been LLM-generated