zlib: accept ArrayBuffer dictionary in Zstd#64599
Merged
nodejs-github-bot merged 3 commits intoJul 21, 2026
Merged
Conversation
Fixes: nodejs#64598 Signed-off-by: islandryu <shimaryuhei@gmail.com>
islandryu
force-pushed
the
zstd-arraybuffer-dictionary
branch
from
July 19, 2026 14:25
d2fcfac to
61b8668
Compare
jasnell
reviewed
Jul 19, 2026
jasnell
approved these changes
Jul 19, 2026
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64599 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.01%
==========================================
Files 741 741
Lines 241976 241983 +7
Branches 45543 45551 +8
==========================================
+ Hits 218116 218158 +42
+ Misses 15379 15345 -34
+ Partials 8481 8480 -1
π New features to boost your workflow:
|
Co-authored-by: James M Snell <jasnell@gmail.com>
Signed-off-by: islandryu <shimaryuhei@gmail.com>
lpinca
approved these changes
Jul 19, 2026
Collaborator
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64599 β Done loading data for nodejs/node/pull/64599 ----------------------------------- PR info ------------------------------------ Title zlib: accept ArrayBuffer dictionary in Zstd (#64599) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch islandryu:zstd-arraybuffer-dictionary -> nodejs:main Labels zlib, needs-ci, commit-queue-squash Commits 3 - zlib: accept ArrayBuffer dictionary in Zstd - Update lib/zlib.js - zlib: import Uint8Array from primordials Committers 2 - islandryu <shimaryuhei@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/64599 Fixes: https://github.com/nodejs/node/issues/64598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64599 Fixes: https://github.com/nodejs/node/issues/64598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Sun, 19 Jul 2026 14:09:57 GMT β Approvals: 2 β - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64599#pullrequestreview-4731048915 β - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64599#pullrequestreview-4731357978 β Last GitHub CI successful βΉ Last Full PR CI on 2026-07-20T06:23:12Z: https://ci.nodejs.org/job/node-test-pull-request/74900/ - Querying data for job/node-test-pull-request/74900/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 64599 From https://github.com/nodejs/node * branch refs/pull/64599/merge -> FETCH_HEAD β Fetched commits as 8cf16b31f61b..db7a201f9535 -------------------------------------------------------------------------------- error: cherry-pick is already in progress hint: try "git cherry-pick (--continue | --abort | --quit)" fatal: cherry-pick failed β Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/29837964050 |
Collaborator
|
Landed in cecfdce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64598