Skip to content

zlib: accept ArrayBuffer dictionary in Zstd#64599

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
islandryu:zstd-arraybuffer-dictionary
Jul 21, 2026
Merged

zlib: accept ArrayBuffer dictionary in Zstd#64599
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
islandryu:zstd-arraybuffer-dictionary

Conversation

@islandryu

Copy link
Copy Markdown
Member

Fixes: #64598

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Jul 19, 2026
Fixes: nodejs#64598
Signed-off-by: islandryu <shimaryuhei@gmail.com>
@islandryu
islandryu force-pushed the zstd-arraybuffer-dictionary branch from d2fcfac to 61b8668 Compare July 19, 2026 14:25
Comment thread lib/zlib.js Outdated
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 90.15%. Comparing base (4f844f4) to head (db7a201).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lib/zlib.js 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64599      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.01%     
==========================================
  Files         741      741              
  Lines      241976   241983       +7     
  Branches    45543    45551       +8     
==========================================
+ Hits       218116   218158      +42     
+ Misses      15379    15345      -34     
+ Partials     8481     8480       -1     
Files with missing lines Coverage Ξ”
lib/zlib.js 98.07% <72.72%> (-0.26%) ⬇️

... and 35 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

islandryu and others added 2 commits July 20, 2026 01:12
Co-authored-by: James M Snell <jasnell@gmail.com>
Signed-off-by: islandryu <shimaryuhei@gmail.com>
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@islandryu islandryu added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64599
βœ”  Done loading data for nodejs/node/pull/64599
----------------------------------- PR info ------------------------------------
Title      zlib: accept ArrayBuffer dictionary in Zstd (#64599)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     islandryu:zstd-arraybuffer-dictionary -> nodejs:main
Labels     zlib, needs-ci, commit-queue-squash
Commits    3
 - zlib: accept ArrayBuffer dictionary in Zstd
 - Update lib/zlib.js
 - zlib: import Uint8Array from primordials
Committers 2
 - islandryu <shimaryuhei@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64599
Fixes: https://github.com/nodejs/node/issues/64598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64599
Fixes: https://github.com/nodejs/node/issues/64598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Sun, 19 Jul 2026 14:09:57 GMT
   βœ”  Approvals: 2
   βœ”  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64599#pullrequestreview-4731048915
   βœ”  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64599#pullrequestreview-4731357978
   βœ”  Last GitHub CI successful
   β„Ή  Last Full PR CI on 2026-07-20T06:23:12Z: https://ci.nodejs.org/job/node-test-pull-request/74900/
- Querying data for job/node-test-pull-request/74900/
βœ”  Build data downloaded
   βœ”  Last Jenkins CI successful
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
βœ”  origin/main is now up-to-date
- Downloading patch for 64599
From https://github.com/nodejs/node
 * branch                  refs/pull/64599/merge -> FETCH_HEAD
βœ”  Fetched commits as 8cf16b31f61b..db7a201f9535
--------------------------------------------------------------------------------
error: cherry-pick is already in progress
hint: try "git cherry-pick (--continue | --abort | --quit)"
fatal: cherry-pick failed
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/29837964050

@islandryu islandryu added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 21, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2026
@nodejs-github-bot
nodejs-github-bot merged commit cecfdce into nodejs:main Jul 21, 2026
82 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in cecfdce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zstd silently ignores an ArrayBuffer passed as the dictionary option

4 participants