Replace the naive per-char impl with scan-to - #4
Merged
Conversation
Replace single-char reader.read() loop with bulk read into a char[8192] buffer and scan for newline over the array. Eliminates per-character method dispatch overhead (synchronized in BufferedReader) while preserving resumability semantics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01761H3KorZV49nqsiWMqJAz
Standalone benchmark with the old per-char implementation inlined for A/B comparison. Covers varying row counts, column counts, and field lengths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01761H3KorZV49nqsiWMqJAz
Replace per-char charAt loop with indexOf('\n', start), a HotSpot
intrinsic that scans via SIMD. 1.4x-6.5x speedup on decode, scaling
with field length. Update benchmark to cover decode path.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01761H3KorZV49nqsiWMqJAz
Retained in branch history for reference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01761H3KorZV49nqsiWMqJAz
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01761H3KorZV49nqsiWMqJAz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.