fix(cmd): scope bean completion to selected domain - #97
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bean completion includes beans from every domain even after a domain is selected. Scope the shared candidate query to the selected domain, preserving both fully qualified and short names. When no domain is selected, completion still offers fully qualified names from all domains.
Add seven integration cases covering
bean,get -b/--bean,set -b/--bean, domain changes, and clearing the domain. The tests exercise console completion against a real JMX connection and reproduce the unwanted cross-domain suggestions before the fix.Validation:
JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-25.jdk/Contents/Home mvnd -B --no-transfer-progress clean verifypassed with 352 unit tests and 85 integration/end-to-end tests.Closes #88.