Fix Mac Unit Tests in AR - #20059
Draft
EnterTheArcane wants to merge 6 commits into
Draft
Fix Mac Unit Tests in AR#20059EnterTheArcane wants to merge 6 commits into
EnterTheArcane wants to merge 6 commits into
Conversation
Update platform-sensitive test setup and affected implementations for current macOS and Qt behavior while retaining cross-platform correctness. Use portable SIMD masks, deterministic focus handling, and targeted signed image compression coverage. Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
…al and add unit test for named pipe case Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
… transitions Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
Construct the masks through the SIMD API instead of loading them from function-static arrays. This removes the storage and alignment behavior associated with the VectorN constructor crash under MSVC. Signed-off-by: EnterTheArcane <96613937+EnterTheArcane@users.noreply.github.com>
EnterTheArcane
marked this pull request as draft
September 4, 2026 04:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Mac-Test job on current GitHub-hosted macOS runners and enables it for normal AR runs, not just manual workflow dispatches.
The first blocker was the macOS Qt package linking QtDBus, even though O3DE doesn't use it. This updates Qt to
6.10.2-rev7, built without D-Bus by o3de/3p-package-source#399.The remaining changes address failures exposed once the tests could launch, including FileWatcher shutdown behavior, named-pipe file-length queries, task tests under limited worker counts, and a SIMD mask implementation that passed on ARM but crashed Windows tests.
A few test changes are worth calling out:
QApplication::setActiveWindow. The warning suppression is scoped to those calls. I left a note to refactor the tests so we can remove it later.How was this PR tested?
AzCore,AzToolsFramework,EditorLib,ImageProcessingAtom.Editor, andAtomToolsFrameworktest suites.AR will cover Windows and Linux. The previous Windows failure was traced to the SIMD mask aliasing and was replaced with the platform SIMD integer-load and bit-cast APIs.