Conversation
With the matrix fixed (#732) opam resolves on all four targets, and two missing system dependencies surface behind it: - ubuntu: wasm_of_ocaml-compiler 6.4.1 fails to build. eliom and ocsigen-toolkit depend on it and its build needs a recent binaryen (wasm-merge); the distro one is too old. The doc workflow already has this step. - macOS: conf-postgresql fails at "pkg-config libpq". Homebrew keeps libpq keg-only, so its pkgconfig directory has to be named explicitly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #732, which fixed the resolution and let the real failures through.
opam now resolves on all four targets (no more "Package conflict" / "No
agreement"), and two missing system dependencies appear behind it:
wasm_of_ocaml-compiler.6.4.1atdune buildwasm-merge); the distro one is too oldconf-postgresql.2atpkg-config libpqpkg-configcannot find itThe binaryen step is copied from this repository's own
doc.yml, which has had itfor a while and builds green; it is the same action js_of_ocaml's CI uses. The
libpq step names Homebrew's pkgconfig directory, which is the documented way
around keg-only formulae.
build.ymlruns on pull requests, so this PR is where it gets checked. I cannotbuild the dependency tree locally, and I would rather say so than claim more than
I verified: what I know is that these are the two errors the last run reported, and
that
doc.ymlproves the binaryen step works on ubuntu with this dependency set.If macOS then trips on something else, the log will name it.