Save places in the app - #64
Merged
Merged
Conversation
The bookmark on a place's card saves it with a name and the directions to its door. Saved places are listed from a button on the map, drawn on it as small rings under the drawing, and found first as anything is typed, with no connection. Opening one goes there with its own directions, and Go on a saved place's whole name goes straight to it. The card shows a saved place's name however it was reached. Saving a code again changes it rather than listing it twice, and removing it is in the same dialog, where it is a deliberate choice. They are kept in one small file in the app's own files, which the device's backup includes, written whole and moved into place so a crash cannot leave half a list. No account and no export, by the decision the website made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Saved places, the R1 scope you settled: kept on the device, no contacts, no print, no export.
cafefinds "Café Rosa". Go on a saved place's whole name goes straight to it.Where they are kept
One small JSON file in the app's own files, which the device's backup includes, so a new phone has them. It is written whole to a file beside it and moved into place, so a crash halfway through cannot leave half a list. Writes run one at a time, in order. There is no account to sync to and no export, by the decision the website made when it took its export down. Syncing to the watch comes with Wear OS in R2.
Checks
SavedTest(7 tests):officeeach went back, labelled "A saved place", with the directions in the address and in the link (&n=Side+door+on+Adelaide).offlisted Office first.