ci: link, leakage and API-spec gates, plus the docs site's missing headers - #13
Open
LKSNDRTMLKV wants to merge 8 commits into
Open
ci: link, leakage and API-spec gates, plus the docs site's missing headers#13LKSNDRTMLKV wants to merge 8 commits into
LKSNDRTMLKV wants to merge 8 commits into
Conversation
… be committed to a public repo
…ng a removed product-category schema and an internal decision-record reference from published content
…ne, and give the docs site the headers and robots file the landing site already had
…pe the workflow token to read-only
Deploying odal-node-docs with
|
| Latest commit: |
9f3c7e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d948b615.odal-node-docs.pages.dev |
| Branch Preview URL: | https://chore-ci-gates.odal-node-docs.pages.dev |
Deploying odal-node-landing with
|
| Latest commit: |
9f3c7e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6073328f.odal-node-landing.pages.dev |
| Branch Preview URL: | https://chore-ci-gates.odal-node-landing.pages.dev |
…ft check is deterministic and cross-repo changes are not deadlocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three CI gates the site had no mechanism for, and closes the findings each one exists to catch. Also carries two prerequisite commits: a
.gitignoreguard for local-only directories, and a clean resync of the vendored OpenAPI spec.Merge this first. The
.gitignoreguard is not in effect on branches that lack it, and this repo is public.What it adds
disttrees.astro checktreats a markdown link target as an opaque string, which is why four[Licensing](/engine/licensing)links passedcheckand 404'd in production. Readingdistalso means Astro's redirect stubs are followed via their own<a href>, and cross-site links resolve against the other site's build — the only way a docs → landing link was ever going to be caught.public/. The one served instance of an internal decision-record number was inpublic/openapi.yaml; a source-tree-only convention would never have found it. It also asksgit ls-fileswhether any local-only directory is tracked, because the content scan skips those by design.dpp-engineso the comparison has something to compare against.permissions: contents: readon the workflow._headersandrobots.txtfor the docs site, which had neither — 21 pages and a 2.87 MB bundle shipping with noCache-Controland none of the four security headers the marketing site gets.Every gate was tested against a known-bad input
--checkand plain sync)Two fixes needed to make the gates green
A gate that cannot go green is not a gate. The four
Licensinglinks and one/roadmaplink were removed and the/design/open-coreredirect repointed at a live page. Whether to publish the licensing page is a separate question, handled in a later PR.Fourteen source comments cited private documents. Each already stated its own substance, so the pointer was pure leak; they now state the rule inline.
Verification:
pnpm -r buildgreen ·pnpm -r check0 errors / 0 warnings / 5 hints · 796 links across 43 pages resolve · leakage clean · spec matches.