chore(deps): upgrade both sites to Astro 7 - #17
Open
LKSNDRTMLKV wants to merge 5 commits into
Open
Conversation
…ocial config and the deprecated zod re-export
…ft check is deterministic and cross-repo changes are not deadlocked
Deploying odal-node-docs with
|
| Latest commit: |
fda9a0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba5db014.odal-node-docs.pages.dev |
| Branch Preview URL: | https://chore-astro-7.odal-node-docs.pages.dev |
Deploying odal-node-landing with
|
| Latest commit: |
fda9a0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a998e80d.odal-node-landing.pages.dev |
| Branch Preview URL: | https://chore-astro-7.odal-node-landing.pages.dev |
# Conflicts: # .github/workflows/ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both sites were pinned to
astro: ^5, and six advisories against the installed 5.18.2 have fixes that land only in 6.4.6, 7.0.4, 7.0.6 and 7.0.10 — unreachable from that line. Stacked on #16.Real exposure today is close to zero: these are
output: "static"sites with no SSR and no user input anywhere, and the vulnerable classes need dynamic parameters to exploit. The reason to do it now is that "we are pinned to a line that no longer receives security fixes" is a bad answer to a security questionnaire, it gets worse every month, and with nothing deployed a breaking upgrade is free.Result
pnpm audit: 24 advisories → 10. All six Astro advisories cleared. The remaining ten are build-time or dev-server issues in transitive dependencies (postcss, and a Vue chain pulled in by the bundled API reference) that do not reach a static deploy.Migration needed
Two changes, both well-documented upstream:
socialconfig changed from an object to an array of link items in v0.33.0.zre-exported fromastro:contentis deprecated; imported fromastro/zodinstead.That was the whole of it. No template, routing, or content-collection changes.
The audit gate
pnpm audit --audit-level criticalis now part of CI. It is set tocriticalrather thanhighdeliberately —highfails today on those ten transitive advisories, and a gate that is red on arrival is how a red CI becomes normal. Tighten it tohighonce they clear. Verified both ways:criticalexits 0,highexits 1, so the gate demonstrably fails when it should.Verification: both sites build ·
pnpm -r check0 errors / 0 warnings / 5 hints, the same baseline as before the upgrade · 824 links resolve · leakage clean · spec matches.