fix(agent): recover Qwen/Hermes wrapper calls, reject non-string payloads, unfilter codex models - #6295
Open
Spoofiecus wants to merge 2 commits into
Open
fix(agent): recover Qwen/Hermes wrapper calls, reject non-string payloads, unfilter codex models#6295Spoofiecus wants to merge 2 commits into
Spoofiecus wants to merge 2 commits into
Conversation
…oads, unfilter codex models
Spoofiecus
force-pushed
the
p2-intent
branch
from
September 15, 2026 06:39
f39aa5f to
3fa32ce
Compare
Author
This was referenced Sep 15, 2026
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three confirmed bugs in the Qwen/Hermes text-mode tool-call intake:
command/codepayloads were coerced intoToolBlockcontent that is not astr(crash/mangled execution). Now fail closed, matching the email-tools precedent.Target branch
dev, notmain.Type of Change
Linked Issue
Fixes #6014
Fixes #6013
Fixes #6012
Checklist
devuvicorn app:app, native venv, 127.0.0.1:7001) and verified the change works. Details in How to Test.How to Test
python -m pytest -q tests/test_tool_parsing_wrapper_recovery.py-> 7 passed (one per issue plus the agent: tool-call parsing and schema hardening subtracker #5333 and no-regression cases).python -m pytest -q tests/test_tool_parsing_hermes_json.py tests/test_redos_xml_tool_parsers.py-> existing parser contracts still green (ReDoS bounds included).uvicorn app:appon 127.0.0.1:7001 with these changes;/api/healthhealthy.Note: the #6218 codex-discovery fix was removed from this PR - #6244 already owns it.