Skip to content

fix(agent): recover Qwen/Hermes wrapper calls, reject non-string payloads, unfilter codex models - #6295

Open
Spoofiecus wants to merge 2 commits into
odysseus-dev:devfrom
Spoofiecus:p2-intent
Open

Spoofiecus wants to merge 2 commits into
odysseus-dev:devfrom
Spoofiecus:p2-intent

Conversation

@Spoofiecus

@Spoofiecus Spoofiecus commented Sep 14, 2026

Copy link
Copy Markdown

Summary

Fixes three confirmed bugs in the Qwen/Hermes text-mode tool-call intake:

Target branch

  • This PR targets dev, not main.

Type of Change

  • Bug fix (non-breaking - fixes a confirmed issue)

Linked Issue

Fixes #6014
Fixes #6013
Fixes #6012

Checklist

  • I searched open issues and open PRs - this is not a duplicate.
  • This PR targets dev
  • My changes are limited to the scope described above - no unrelated refactors or whitespace changes mixed in.
  • I actually ran the app (uvicorn app:app, native venv, 127.0.0.1:7001) and verified the change works. Details in How to Test.

How to Test

  1. python -m pytest -q tests/test_tool_parsing_wrapper_recovery.py -> 7 passed (one per issue plus the agent: tool-call parsing and schema hardening subtracker #5333 and no-regression cases).
  2. python -m pytest -q tests/test_tool_parsing_hermes_json.py tests/test_redos_xml_tool_parsers.py -> existing parser contracts still green (ReDoS bounds included).
  3. Runtime: booted uvicorn app:app on 127.0.0.1:7001 with these changes; /api/health healthy.

Note: the #6218 codex-discovery fix was removed from this PR - #6244 already owns it.

@github-actions github-actions Bot added needs work PR description incomplete — please update before review needs runtime validation Runtime validation not attested — tick the app-run box after running it, or state the gap labels Sep 14, 2026
@Spoofiecus Spoofiecus changed the title P2 intent fix(agent): recover Qwen/Hermes wrapper calls, reject non-string payloads, unfilter codex models Sep 14, 2026
@github-actions github-actions Bot added ready for review Description complete — ready for maintainer review and removed needs work PR description incomplete — please update before review needs runtime validation Runtime validation not attested — tick the app-run box after running it, or state the gap labels Sep 14, 2026
@Spoofiecus Spoofiecus mentioned this pull request Sep 14, 2026
16 tasks
@Spoofiecus

Copy link
Copy Markdown
Author

Heads-up while comparing open PRs: this PR originally also carried the #6218 codex-discovery fix. #6244 by @ashvinctrl already owns that fix, so it has been removed here (diff now: the #6012/#6013/#6014 Qwen/Hermes parser fixes only). Deferring #6218 to #6244.

This was referenced Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Description complete — ready for maintainer review

Projects

None yet

1 participant