fix(cookbook): lossless launch-command preview round-trip (#5979) - #6310
Open
Spoofiecus wants to merge 1 commit into
Open
Spoofiecus wants to merge 1 commit into
Spoofiecus wants to merge 1 commit into
Conversation
Spoofiecus
force-pushed
the
p4-slice3-5979
branch
from
September 16, 2026 06:28
26c12b6 to
dcf224a
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The Serve-panel command pipeline corrupted quoted

$(...)model-arg commands across display->launch cycles: multi-line previews kept their\continuations inline (uncollapsed), and the tokenizer fused backslash+space into\ --hosttokens, compounding each edit. The launched shell passed a space-prefixed--modelword, which llama-server rejects witherror: invalid argument: --model(issue #5979).Target branch
**dev**, notmain. All PRs land indev.Type of Change
Linked Issue
Fixes #5979
Checklist
devuvicorn app:app, native venv) and verified the change works; details in How to Test.How to Test
./venv/bin/python -m pytest tests/test_cookbook_serve_cmd_js.py— 6 passed (Node-driven: clean round trip, stable collapse, mangled-input self-heal, quoted escapes/spaces using the issue's exact$(printf %s ... )model path, MODEL_FILE prelude, env-first ordering).node --check static/js/cookbookServe.js static/js/cookbook.js— clean../venv/bin/python -m pytest tests/test_cookbook_serve_cmd_js.py tests/test_cookbook_helpers.py tests/test_cookbook_stale_shim_recovery.py— 97 passed, 1 skipped.Rule 08: curl-served MD5 matches disk for cookbookServe.js + cookbook.js.
Live: dev
:7001serves the new bytes (healthy); original:7000untouched.Pre-existing 4-test baseline failures are the workspace baseline (rule 30), unrelated to this diff.
Scope is the editor/launch formatter only; no runner, API, backend arg-parsing, or mobile-sheet change. The PR that wraps this phase also carries the cache-buster bumps for the two touched JS files (rule 07).
Visual / UI changes
Screenshots / clips