test(cli): K2 ingested validate dry-run + pronoun source guard#185
Open
oldrepublicwizard wants to merge 1 commit into
Open
test(cli): K2 ingested validate dry-run + pronoun source guard#185oldrepublicwizard wants to merge 1 commit into
oldrepublicwizard wants to merge 1 commit into
Conversation
Reject pronoun tokens in NLP source paths (e.g. "rename them to …") and add GuideIngestionTests coverage for validate --dry-run-only on the site-scraped K2 Full fixture TOML.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
them,it,files, etc.) as NLP draft source paths so prose like "rename them to PLC_CompPnl_b" no longer emits<<modDirectory>>\them.K2FullGuideFixture_ValidateDryRunOnly_ExitsZero— convert site-scraped K2 Full fixture with--parse-directions, thenvalidate --dry-run-onlyon template KOTOR/mod dirs (matchesFullBuildCliPipelineTestspattern).DraftInstructions_RenameThemProse_DoesNotUsePronounAsSourceregression.Context
Stacks on #184 (NLP draft coverage). Validates the next step in the K2 Full round-trip: ingested TOML loads and VFS dry-run completes on empty template dirs (missing mod archives are expected until Fetch Downloads).
Test plan
dotnet test --filter FullyQualifiedName~DraftInstructions_RenameThemProsedotnet test --filter FullyQualifiedName~K2FullGuideFixture_ValidateDryRunOnlyconvert -i k2_full_guide.md --parse-directions→ no\\themsources in output TOML