feat(cli): K2 round-trip download+extract smoke#191
Open
oldrepublicwizard wants to merge 3 commits into
Open
Conversation
Merge golden URLs with ingested NLP instructions via K2FullGuideRoundTripHelper, fix ResourceRegistry filename hydration from ModLinkFilenames, and add LongRunning network test proving Silent Sion downloads and extracts after round-trip overlay.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
added 2 commits
July 17, 2026 14:15
Silent Sion and similar mods extract archives into nested folders, but NLP Move drafts only targeted the mod workspace root. Expand single-file Move sources with depth-aware wildcards, tighten round-trip overlay refinement, and assert Override install in the LongRunning round-trip smoke.
Note nested loose-file Move source expansion used by the LongRunning Silent Sion smoke.
4 tasks
oldrepublicwizard
pushed a commit
that referenced
this pull request
Jul 18, 2026
Extend the #191 round-trip harness with Prestige Class folder-Move coverage, overlay helper assertions, and agent script --mod routing for network smoke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
K2FullGuideRoundTripHelperto build round-trip TOMLs: goldenResourceRegistryURLs + ingested NLP install instructions, with Extract injection and Move refinement from Directions prose.ModComponentSerializationServiceto mergeModLinkFilenamesarchive names into existingResourceRegistryentries when nestedFilesmaps deserialize empty.<<modDirectory>>/*…/filenamesources so post-extract paths (e.g.Silent Sion Restoration/Silent Sion Restoration/153sion.dlg) resolve to Override.K2FullGuideFixture_RoundTripSilentSion_DownloadAndInstalls_LongRunningproves DeadlyStream download → extract →Override/153sion.dlgafter neocities↔golden merge overlay.scripts/agents/k2_merged_roundtrip_download_install_smoke.shNotes
KOTOR2_Full.tomlattaches incorrect Effixian instructions/URLs to Silent Sion; round-trip overlay intentionally replaces instructions from ingested NLP drafts.Test plan
dotnet test --filter FullyQualifiedName~MergedSilentSion_ResourceRegistryListsArchiveFilenamesdotnet test --filter FullyQualifiedName~RoundTripHelper_OverlaySilentSion_AddsExtractForRegistryArchivedotnet test --filter FullyQualifiedName~DraftInstructions_SilentSionMoveJust_IncludesNestedSearchPathsdotnet test --filter FullyQualifiedName~K2FullGuideFixture_IngestedSilentSion_InstallsFromNestedExtractFolderdotnet test --filter FullyQualifiedName~K2FullGuideFixture_RoundTripSilentSion_DownloadAndInstalls_LongRunning(~2 min, network)Stacks on #190.