Apply selection_foreground to the Visual highlight - #7
Open
ishansing wants to merge 1 commit into
Open
Conversation
Visual and VisualNOS only set a background, so selected text falls back to the regular foreground. On themes whose selection color is close to the foreground, selected text becomes unreadable. Honor selection_foreground as the fg so themes can control selection text contrast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VisualandVisualNOSonly set a background (bg = c.bg_visual), so selected text falls back to the regularforeground. On themes whose selection color sits close to the foreground, selected text becomes unreadable (e.g. light selection + light text).selection_foregroundis already part of the palette (declared incolors/init.lua, documented in the README, and passed through by Omarchy themes viacolors.toml) but is never applied.Fix
Set the selection
fgfromselection_foreground, keeping the existingbg:Verification
With a theme defining
selection_foreground = \#05060d\andselection = \#b6cfdf\:The default
#dfe6ebremains unchanged for users who never set the value, so existing themes are unaffected.