Conversation
Member
Author
|
For further discussion use PR |
melanconj
reviewed
Sep 16, 2026
| or the key specified by the requested KeyID is not an asymmetric key pair, an invalid | ||
| key ID fault shall be produced and no CSR shall be generated.</para> | ||
| <para>If no key is stored under the requested KeyID or the key specified by the | ||
| requested KeyID is not an asymmetric key pair, an invalid key ID fault shall be |
Contributor
There was a problem hiding this comment.
I feel is not an asymmetric key pair would be clearer as does not contain a private key? Unless I misunderstood the meaning we wanted to convey
Member
Author
There was a problem hiding this comment.
Didn't touch that part but agree that it could be improved. How about simplifying to If the requested KeyID does not refer to an asymmetric key pair, an invalid key ID fault shall be produced and no CSR shall be generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #813. Simplify description without changing requirements.