Skip to content

chore: standardize/update release please config - #423

Merged
toddbaert merged 1 commit into
mainfrom
chore/release-plz-standardization
Sep 25, 2026
Merged

toddbaert merged 1 commit into
mainfrom
chore/release-plz-standardization

Conversation

@toddbaert

Copy link
Copy Markdown
Member

Standardizes this repo's release-please setup. Part of open-feature/community-tooling#128.

  • pin googleapis/release-please-action@45996ed…307cf7 # v5
  • token: ${{ secrets.RELEASE_PLEASE_ACTION_TOKEN }}
  • signoff configured in release-please-config.json (removes deprecated command/default-branch/signoff inputs); fixes DCO on release PRs
  • release gate uses the always-emitted, monorepo-safe plural releases_created via fromJSON(... || false)
  • add a concurrency guard to serialize release-please runs

Single signed-off commit; no changes to custom publish/build steps.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
toddbaert requested a review from a team as a code owner September 25, 2026 14:27
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fb331073-53ee-4a59-bfc6-b11c06cb9729

📥 Commits

Reviewing files that changed from the base of the PR and between aafeefc and e2e4a17.

📒 Files selected for processing (1)
  • .github/workflows/release-please.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now limits concurrent runs by Git ref without cancelling in-progress runs. It upgrades Release Please to v5 and parses its release output before deciding whether to run the image-build job.

Changes

Release workflow

Layer / File(s) Summary
Release workflow controls
.github/workflows/release-please.yml
The workflow groups runs by Git ref without cancelling in-progress runs. It uses Release Please v5 and its releases_created output. The image-build condition parses the output as JSON and defaults an empty value to false.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: bacherfl

Merge Risk: ⚪ Minimal · up to e2e4a

The workflow builds and pushes images only after a release is created. No current merge-blocking risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to e2e4a

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/release-please.yml: Adds workflow concurrency grouped by Git ref, with in-progress runs not cancelled.
  • observed — Modified behavior in .github/workflows/release-please.yml: Upgrades the Release Please action from v4 to v5 and changes release_created to use the action’s releases_created output.
  • observed — Modified behavior in .github/workflows/release-please.yml: The image-build condition now parses the release output as JSON and defaults an empty value to false before evaluating whether the job runs; previously it evaluated the output directly.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: standardizing and updating the release-please configuration.
Description check ✅ Passed The description directly explains the release-please updates, including the v5 action, token, signoff configuration, release gate, and concurrency guard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@toddbaert
toddbaert merged commit 1412f09 into main Sep 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant