Conversation
The normative description of the assets added alongside: what a TCK implementation must do, what each capability asserts and when withholding one is a sanctioned choice rather than a defect, the control-API contract, the extension point, and the run-integrity checks. Stated as normative blockquotes rather than numbered requirements, following Appendix A -- specification.json is built from the numbered sections and no appendix contributes to it. Whether any of this should become numbered is a TSC decision, recorded as an open question. The assets README hands the capability vocabulary back here, so it has one home rather than two that can disagree. Experimental and non-normative. Tracked in #417. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Appendix F: Provider Conformance (TCK) — the normative description of the conformance assets in #423. What a TCK implementation must do, what each capability asserts, the control-API contract, the extension point, and the run-integrity checks.
Marked experimental and non-normative.
How the requirements are expressed
As normative blockquotes (58 of them), not numbered requirements — following Appendix A, since
specification.jsonis built from the numbered sections and no appendix contributes to it.Whether any of this should become numbered normative sections is a TSC decision, recorded as an open question rather than assumed. That is the main thing I would like a view on.
Design decisions worth reviewing
Each is argued in the appendix; this is the index.
@lifecycleand@eventsare separate, because a provider can initialise against its backend without emitting events, and vice versa.@numeric-coercionis borrowed, not specified. The rule comes from a flagd ADR, not from the specification. An earlier draft claimed the opposite and called withholding the tag "an admission of a known bug" — wrong, and corrected. Gap: #430.@string-typingand@fully-typed-valuesare two tags because one hid a bug. Three providers over one Flagsmith backend: two reportTYPE_MISMATCHfor a boolean and an integer asked as strings, one stringifies them, and all three stringify the float and the structure. The latter is the backend's shape, the former a provider defect; one tag reported the defect as a permitted absence. Gap: #433.One home for the vocabulary
#423 carries the capability table in
assets/provider-tck/README.mdso the tags are defined while this is in review. This PR moves it here and leaves a pointer behind — the appendix owns it, and two copies would be able to disagree.Open questions
@large-integerscovers up to 2^53 − 1; 32- versus 64-bit accessors are not modelled. Part of #430.@cachingis reserved.Answers #417's Q1 (directory layout, forced rather than chosen) and Q4 (numeric coercion stays a capability). Q2, Q3, Q5 and Q6 stay open; Q7 is split into #424.