Fix inverted scope_info_enabled and target_info_enabled declarative config flags - #8750
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8750 +/- ##
============================================
- Coverage 91.29% 91.28% -0.01%
+ Complexity 10498 10495 -3
============================================
Files 1006 1006
Lines 28338 28338
Branches 3581 3579 -2
============================================
- Hits 25870 25869 -1
Misses 1675 1675
- Partials 793 794 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thswlsqls
marked this pull request as ready for review
September 2, 2026 04:04
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-02 14:35 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8749
Description
PrometheusComponentProvider.create()passed!valuetosetOtelScopeLabelsEnabledandsetTargetInfoMetricEnabled, so both declarative config options did the opposite of what they say.without_scope_info/without_target_infoto the positive form but kept the!.opentelemetry-configurationschema and the generatedExperimentalPrometheusMetricExporterModeljavadoc define both keys as "if omitted or null, true is used".Testing done
MetricReaderFactoryTest's "pull prometheus configured" case feedsfalsefor both keys but expected the builder defaults (true), so it only passed while the bug existed. The corrected expectation fails before this change and passes after.:sdk-extensions:declarative-configbecause that is whereComponentProvidercoverage sits;:exporters:prometheushas:api:incubatoronly ascompileOnly../gradlew :exporters:prometheus:check(202 tests) and:sdk-extensions:declarative-config:check(514 tests) pass.internalpackage, no file underdocs/apidiffs/current_vs_latest/.