Complete the truncated channel shutdown comment in UpstreamGrpcSenderProvider - #8753
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
thswlsqls
marked this pull request as ready for review
August 28, 2026 10:26
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-02 14:35 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8753 +/- ##
=========================================
Coverage 91.29% 91.29%
- Complexity 10498 10500 +2
=========================================
Files 1006 1006
Lines 28338 28338
Branches 3581 3581
=========================================
+ Hits 25870 25872 +2
Misses 1675 1675
+ Partials 793 791 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue: trivial comment fix, PR-only per contribution policy.
Description
UpstreamGrpcSenderProvider#createSenderends mid-sentence at "if", so it never states the condition. It has been truncated since Use minimal fallback managed channel when none is specified #6110 (da7796b3b) added it — no full sentence ever existed, so this wording is newly written, not restored.elseruns when noManagedChannelwas configured, so the sender creates the fallback channel and owns it.shutdownChannelstartsfalse, is settrueonly here, and is read only byUpstreamGrpcSender.shutdown()— it expresses channel ownership. Different wording is welcome.Testing done
./gradlew :exporters:sender:grpc-managed-channel:check— BUILD SUCCESSFUL, 3 tests passed (UpstreamGrpcSenderTest); includes spotless, ErrorProne/NullAway, and jApiCmp.docs/apidiffs/current_vs_latest/opentelemetry-exporter-sender-grpc-managed-channel.txtstill readsNo changes., so no apidiff was staged.*IT) and GraalVM native-image tests were not run locally.