Issue 8316 okhttp rejected execution - #8769
Open
Rajkaran-122 wants to merge 2 commits into
Open
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-04 09:49 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8769 +/- ##
============================================
- Coverage 91.29% 91.29% -0.01%
Complexity 10498 10498
============================================
Files 1006 1006
Lines 28338 28338
Branches 3581 3581
============================================
- Hits 25871 25870 -1
Misses 1675 1675
- Partials 792 793 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rajkaran-122
force-pushed
the
issue-8316-okhttp-rejected-execution
branch
from
September 2, 2026 21:30
060b30c to
b0884c5
Compare
jkwatson
reviewed
Sep 2, 2026
Comment on lines
+91
to
+92
| // OkHttp wraps RejectedExecutionException in InterruptedIOException with message "executor | ||
| // rejected" |
Contributor
There was a problem hiding this comment.
these comments aren't useful
jkwatson
approved these changes
Sep 2, 2026
Contributor
Author
|
@jkwatson PTAL when you get a chance. looking forward to getting this merged ,Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The production behavior described by #8316 is already implemented by #8422: OkHttp sender dispatchers are bounded and
RejectedExecutionExceptionis propagated through the sender error callback.The existing OkHttp sender tests verify that an error is received, but they only assert that the error is non-null. This change strengthens those assertions to explicitly verify that the reported error is a
RejectedExecutionException, matching the corresponding JDK sender test behavior.Changes
OkHttpHttpSenderTest.OkHttpGrpcSenderTest.RejectedExecutionException.Testing
Ran the OkHttp sender tests and relevant formatting/checks.
Related issue: #8316