rewrite dac consumer module - #3878
Open
benderl wants to merge 82 commits into
Open
Conversation
* use chargemode enums for chargepoints * fix * flake8 * flake8 * fix amount * use enum also for chargemode selected * fix asdict import * review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* usage type self controlled * fix * review
* calc on time * review
* fix pytest * fixes, pytest * review * fix
* typo * fix * pytest
* IDM: send PV/Hausverbrauch/Batterie via GLT statt Leistungsvorgabe * Lambda: PV-Überschuss statt power_limit an E-Manager senden * Add OVUM CubeSpeicher/MPlus consumer module * IDM: revert scaling factor, fix flake8 formatting * flake8 * Rename send_grid_values to send_values in config.py * Adjust surplus calculation to account for charging power Include charging power in surplus calculation to avoid misreporting surplus to the heat pump. * Update send_values function to send grid power * Add Self_Controlled for IDM and Lambda * flake8: fix syntax error and whitespace in consumer modules Stray pasted line broke lambda_ consumer.py syntax; idm/lambda_/ovum files had trailing whitespace on blank lines and missing EOF newlines.
* clean up * fix loadmanagement * review * review * flake8
openWB#3840) * no charge for loads * consider non charging for consumers and update consumer state messages * flake8 * review
* Vampair * typo * review * review * review
* draft dac * add dataclass object for set_power_limit * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix configuration type hints * fix consumer type hints and errors * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
benderl
force-pushed
the
fixes-dac-comsumer
branch
2 times, most recently
from
August 31, 2026 11:05
c8754c5 to
deaa366
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks generic DAC consumers to support model-driven scaling, live-zero signals, and both M120T outputs.
Changes:
- Centralizes DAC model parameters.
- Adds configurable signal-range mapping.
- Adds separate M120T output selections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
model.py |
Defines model-specific output parameters. |
consumer.py |
Implements generic scaling and Modbus writes. |
config.py |
Adds signal-range configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benderl
force-pushed
the
fixes-dac-comsumer
branch
from
August 31, 2026 11:11
deaa366 to
134ad5e
Compare
LKuemmel
marked this pull request as ready for review
September 7, 2026 06:40
LKuemmel
force-pushed
the
feature_consumer_modules
branch
from
September 7, 2026 13:37
fe16993 to
d06a6eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: openWB/openwb-ui-settings#1070