Update static_route_isis_redistribution_test.go

[AmrNJ]

• Under deviations.SamePolicyAttachedToAllAfis, ensures global oc.IsisTypes_AFI_TYPE_IPV4 and oc.IsisTypes_AFI_TYPE_IPV6 remain enabled so Arista Octa preserves address-family ipv6 unicast.
• Fixed receiver bug sr2.SetTag, _ = sr2.To_NetworkInstance_Protocol_Static_SetTag_Union(tagValueV6).
• Standardized configureTagSet to use oc.UnionUint32(uint32(tagValue)).
• Replaced streaming gnmi.WatchAll with gnmi.LookupAll + net.ParseIP matching over a 2-minute polling window.

https://issuetracker.google.com/550948793

[OpenConfigBot]

Pull Request Functional Test Report for #5945 / 032188d

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-2.12: Static route to IS-IS redistribution	3d31dc8e	Log
Cisco 8000E		RT-2.12: Static route to IS-IS redistribution	d14cb653	Log
Cisco XRd		RT-2.12: Static route to IS-IS redistribution	2dd50be9	Log
Juniper ncPTX		RT-2.12: Static route to IS-IS redistribution	fbf5eacf	Log
Nokia SR Linux		RT-2.12: Static route to IS-IS redistribution	57b1a49b	Log
Openconfig Lemming		RT-2.12: Static route to IS-IS redistribution	565dfef3	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		RT-2.12: Static route to IS-IS redistribution
Cisco		RT-2.12: Static route to IS-IS redistribution
Juniper		RT-2.12: Static route to IS-IS redistribution
Nokia		RT-2.12: Static route to IS-IS redistribution

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the stability and compatibility of the ISIS redistribution test suite. It introduces necessary configuration adjustments to support Arista Octa devices and replaces brittle streaming telemetry watches with a more reliable polling-based verification approach, ensuring consistent test results across different environments.

Highlights

• Arista Octa Compatibility: Updated ISIS redistribution policy configuration to ensure both IPv4 and IPv6 address families remain enabled, preserving compatibility with Arista Octa.
• Test Reliability: Replaced streaming gnmi.WatchAll with a more robust polling mechanism using gnmi.LookupAll and net.ParseIP to verify route prefixes and metrics over a 2-minute window.
• Code Cleanup and Standardization: Standardized tag set configuration to use oc.UnionUint32 and fixed a receiver bug in the static route configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the static route ISIS redistribution test. It fixes a bug in isisImportPolicyConfig where the address family variable was incorrectly mutated, ensures global IPv4 and IPv6 AFI types remain enabled for Arista Octa, corrects a tag union conversion bug in configureStaticRoute, and updates configureTagSet to use UnionUint32. Additionally, the prefix verification functions (verifyPrefix, verifyV6Prefix, verifyPrefixMetric, and verifyV6PrefixMetric) were refactored to use lookup loops with a timeout. There are no review comments, so I have no feedback to provide.