Skip to content

gre_encap - #5947

Open
paramasivamn1 wants to merge 2 commits into
mainfrom
new_sflow
Open

gre_encap#5947
paramasivamn1 wants to merge 2 commits into
mainfrom
new_sflow

Conversation

@paramasivamn1

Copy link
Copy Markdown
Contributor

Please review. This addresses the test requirement for b/437422041

@paramasivamn1
paramasivamn1 requested review from a team as code owners August 24, 2026 06:23
@paramasivamn1
paramasivamn1 requested a review from rohit-rp August 24, 2026 06:23
@OpenConfigBot

OpenConfigBot commented Aug 24, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5947 / 93716fa

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
e03fc002 Log
Cisco 8000E status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
eb64dccb Log
Cisco XRd status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
36574893 Log
Juniper ncPTX status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
96c2e908 Log
Nokia SR Linux status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
da935dad Log
Openconfig Lemming status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
29c33c83 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
Cisco status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
Juniper status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests
Nokia status
status
status
SFLOW-2: sFlow Sampling with Encapsulation and Decapsulation
RT-3.53: Static route based GUE Encapsulation to IPv6 tunnel
TE-16.1: basic encapsulation tests

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces documentation and test plans for validating sFlow sampling functionality in scenarios involving packet encapsulation and decapsulation. It ensures that sFlow samples correctly capture ingress/egress interfaces and packet headers across different tunneling protocols, providing a structured approach for future test implementation.

Highlights

  • New sFlow Test Suite: Added comprehensive test documentation for sFlow sampling with various encapsulation and decapsulation scenarios, including GRE, GUE, and gRIBI-programmed encapsulation.
  • Documentation Updates: Updated existing encapsulation test README files to include sFlow validation requirements and OpenConfig path coverage.
  • Test Registry Update: Registered the new SFLOW-2 test plan in the global test registry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds test plans and documentation for sFlow sampling with encapsulation and decapsulation. Specifically, it adds sFlow sampling test cases for IPv4/IPv6 WCMP encapsulation and decapsulation to the gRIBI basic encapsulation test plan, creates a new test plan (SFLOW-2) covering sFlow sampling with GRE, GUE, and gRIBI encapsulation/decapsulation, and adds sFlow sampling test cases for GUE encapsulated traffic to the static next-hop encapsulation UDP test plan. The reviewer feedback highlights a markdown header level inconsistency in the gRIBI test plan and a placeholder value left in the required DUT platform field of the new SFLOW-2 test plan.

Comment thread feature/gribi/otg_tests/basic_encap_test/README.md
Comment thread feature/sflow/otg_tests/sflow_encap_decap_test/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants