Skip to content

Acctz-3.1: fix shell command authn status - #5963

Open
dipchauh wants to merge 1 commit into
openconfig:mainfrom
nokia:acctz3dot1
Open

Acctz-3.1: fix shell command authn status#5963
dipchauh wants to merge 1 commit into
openconfig:mainfrom
nokia:acctz3dot1

Conversation

@dipchauh

Copy link
Copy Markdown
Contributor

Fix authn status for shell commands to expect SUCCESS similar to other command service types (eg. cli commands) used in the test

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aligns the authentication status expectations for shell commands with existing patterns used for other command service types in the test suite. By updating the status to SUCCESS, the test ensures more accurate validation of shell command authentication.

Highlights

  • Authentication Status Update: Updated the authentication status for shell commands to expect SUCCESS instead of UNSPECIFIED to ensure consistency with other command service types.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #5963 / 2a0e8bc

No tests identified for validation.

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SendShellCommand function in internal/security/acctz/acctz.go to set the authentication status in AuthnDetail to AUTHN_STATUS_SUCCESS instead of AUTHN_STATUS_UNSPECIFIED. There are no review comments, and I have no feedback to provide.

@dipchauh
dipchauh marked this pull request as ready for review August 27, 2026 17:37
@dipchauh
dipchauh requested a review from a team as a code owner August 27, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants