Skip applying decap policy on interface when oc unsupported - #5977
Skip applying decap policy on interface when oc unsupported#5977ijernoiu wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a safety check to ensure that decap policies are not applied to interfaces on devices where OpenConfig support is unavailable. By utilizing a deviation check, the test suite avoids potential configuration errors on unsupported hardware. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5977 / 6ee1dbdVirtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a check in configureInputPolicy to return early if interface policy forwarding via OpenConfig is unsupported on the DUT. However, the reviewer pointed out that when OpenConfig is supported, the function configures the policy in memory but fails to actually push it to the DUT via gNMI. To resolve this, a gnmi.Replace call should be added at the end of the function to apply the configuration.
| @@ -451,7 +451,6 @@ func InterfacePolicyForwardingConfig(t *testing.T, dut *ondatra.DUTDevice, a *at | |||
| } | |||
| } else { | |||
| ApplyPolicyToInterfaceOC(t, pf, params.InterfaceID, params.AppliedPolicyName) | |||
There was a problem hiding this comment.
Remove this file as there are no changes.
| } | ||
|
|
||
| func configureInputPolicy(t *testing.T, dut *ondatra.DUTDevice, tc testCase) { | ||
| if deviations.InterfacePolicyForwardingOCUnsupported(dut) { |
There was a problem hiding this comment.
I noticed that there is no issue tracker with Arista for this behaviour. Please raise one and tag it in deviations.go file.
3 participants
No description provided.