Add FNT test for upcoming backup-next-hop-group trigger API - #5980
Add FNT test for upcoming backup-next-hop-group trigger API#5980aayueshbarui wants to merge 5 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new functional network test (FNT) to verify the gRIBI BACKUP_ACTIVATE trigger API. The test ensures that external gRIBI operations correctly trigger dataplane failover to backup next-hop groups, validates FIB programming feedback, and confirms that telemetry accurately reflects the state of the hardware forwarding path during failover and recovery events. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the test plan and metadata for TE-11.4, which validates gRIBI BACKUP_ACTIVATE hardware convergence and FIB ACK verification. The changes include a detailed README, metadata proto, and registration in the test registry. The review feedback points out a placeholder PR link in the README, a violation of the Network Assignments style guide due to the use of private IP addresses in the transit tunnel configuration, and an unnecessary whitespace placeholder in the test registry's exec field.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Feature YANG PR openconfig/public#1541