Skip to content

Add FNT test for upcoming backup-next-hop-group trigger API - #5980

Open
aayueshbarui wants to merge 5 commits into
openconfig:mainfrom
aayueshbarui:main
Open

Add FNT test for upcoming backup-next-hop-group trigger API#5980
aayueshbarui wants to merge 5 commits into
openconfig:mainfrom
aayueshbarui:main

Conversation

@aayueshbarui

Copy link
Copy Markdown

Feature YANG PR openconfig/public#1541

@aayueshbarui
aayueshbarui requested review from a team as code owners September 3, 2026 16:45
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new functional network test (FNT) to verify the gRIBI BACKUP_ACTIVATE trigger API. The test ensures that external gRIBI operations correctly trigger dataplane failover to backup next-hop groups, validates FIB programming feedback, and confirms that telemetry accurately reflects the state of the hardware forwarding path during failover and recovery events.

Highlights

  • New Test Case Addition: Added a new FNT test case (TE-11.4) to validate gRIBI BACKUP_ACTIVATE functionality, focusing on hardware convergence and FIB ACK verification.
  • Test Documentation: Created a comprehensive README detailing the test topology, procedure, and expected outcomes for IPv4, IPv6, and hierarchical tunnel scenarios.
  • Registry Update: Registered the new test case in the global test registry to ensure it is tracked and available for execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the test plan and metadata for TE-11.4, which validates gRIBI BACKUP_ACTIVATE hardware convergence and FIB ACK verification. The changes include a detailed README, metadata proto, and registration in the test registry. The review feedback points out a placeholder PR link in the README, a violation of the Network Assignments style guide due to the use of private IP addresses in the transit tunnel configuration, and an unnecessary whitespace placeholder in the test registry's exec field.

Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md Outdated
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md Outdated
Comment thread testregistry.textproto Outdated
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md Outdated
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md Outdated
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md Outdated
Comment thread feature/gribi/otg_tests/backup_nhg_trigger_test/README.md
aayueshbarui and others added 4 commits September 4, 2026 14:20
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants