Skip to content

Adding aggregare drain test - #5984

Open
rohit-rp wants to merge 2 commits into
openconfig:mainfrom
rohit-rp:aggregate_admin_down_drain
Open

Adding aggregare drain test#5984
rohit-rp wants to merge 2 commits into
openconfig:mainfrom
rohit-rp:aggregate_admin_down_drain

Conversation

@rohit-rp

@rohit-rp rohit-rp commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

System Test Plan see for more info: b/540868611

  • Objective: Verify that administratively disabling a LAG interface (e.g., Port-Channel) via gNMI brings down associated protocols and stops all traffic on the aggregate.
    • Interfaces Used: gNMI, BGP/ISIS, Traffic Generator
    • Expected Outcome Summary: Similar to 7.1, but applied to the LAG master interface.

@rohit-rp
rohit-rp requested review from a team as code owners September 4, 2026 14:01
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new system test plan designed to validate the administrative drain functionality of Link Aggregation Group (LAG) interfaces. By leveraging gNMI to toggle the interface status, the test ensures that traffic is properly stopped and routing protocols (BGP/IS-IS) react as expected, maintaining network stability and correct operational states.

Highlights

  • New Test Case Added: Added a new system test (RT-5.17) to verify that administratively disabling a LAG interface via gNMI correctly drains traffic and brings down associated protocols.
  • Test Documentation: Created a comprehensive README detailing the test procedure, environment setup, and expected OpenConfig path coverage.
  • Registry Update: Registered the new test case in the global test registry to ensure it is tracked and accessible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Sep 4, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test plan (RT-5.17) for Aggregate Interface (LAG) Drain via Admin Down, including a README, metadata, and registration in testregistry.textproto. The review feedback highlights a critical mismatch where the metadata file specifies a 2-link testbed (TESTBED_DUT_ATE_2LINKS) while the README requires a 4-port topology (atedut_4.testbed). Additionally, a minor consistency improvement is suggested for the phrasing of steps in the README.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rohit-rp rohit-rp added the systemTest Systematic Iron gate test plan label Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

systemTest Systematic Iron gate test plan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants