[README] Improve and enhance gRIBI GET RPC test

[rohit-rp]

System Test Plan see for more info: b/540866941

• Objective: Validate that gRIBI Get requests accurately, completely, and efficiently return the current state of the gRIBI AFT, testing different Get request parameters.

• Interfaces Used: gRIBI, gNMI

• Expected Outcome Summary:

  1. Get All: After programming a diverse set of entries, a Get request for all network instances returns exactly those entries and their full parameters, matching what was programmed.
  2. Get Specific Network Instance: A Get request for a specific network instance returns only the entries within that instance.
  3. Get Non-Existent: A Get request for a non-existent network instance returns an empty result or appropriate indication, without error.
  4. Consistency with Telemetry: The results of Get operations are consistently aligned with the state reported via gNMI AFT streaming telemetry.
  5. (If Applicable) Filtering within Get: If the gRIBI Get API supports any form of filtering (e.g., by key, type), test that these filters work correctly.
  6. Performance: While not the primary focus of this section, Get operations on a large AFT should complete within a reasonable time.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gRIBI Get RPC test documentation to provide a more comprehensive validation suite. It introduces structured test cases for verifying gRIBI Get operations under various conditions, including scale, multi-client scenarios, and specific network instance configurations, ensuring robust behavior of the gRIBI implementation.

Highlights

• Expanded Test Coverage: The gRIBI Get RPC test plan has been significantly enhanced to include scale testing, non-leader client validation, AFT filtering, and negative test cases.
• Updated Test Procedure: The test procedure now includes detailed steps for configuring multiple network instances, verifying telemetry consistency, and validating data plane programming with traffic.
• Documentation Updates: Updated the OpenConfig path coverage and platform requirements to reflect the new test scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5986 / 86c1629

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-5.1: gRIBI Get RPC	2984c1cd	Log
Cisco 8000E		TE-5.1: gRIBI Get RPC	050dcce8	Log
Cisco XRd		TE-5.1: gRIBI Get RPC	fa038785	Log
Juniper ncPTX		TE-5.1: gRIBI Get RPC	0002299e	Log
Nokia SR Linux		TE-5.1: gRIBI Get RPC	724d4274	Log
Openconfig Lemming		TE-5.1: gRIBI Get RPC	845781d4	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		TE-5.1: gRIBI Get RPC
Cisco		TE-5.1: gRIBI Get RPC
Juniper		TE-5.1: gRIBI Get RPC
Nokia		TE-5.1: gRIBI Get RPC

Help

[gemini-code-assist]

Code Review

This pull request updates the test plan for the gRIBI Get RPC test in README.md by expanding the procedure into detailed test cases (TestID-5.1.1 through TestID-5.1.6) covering scale, non-leader clients, filtering by AFT type, specific network instances, unresolved next-hops, and negative scenarios. It also updates the OpenConfig path coverage and specifies FFF as the required DUT platform. The reviewer suggested resolving an ambiguity in the unresolved next-hop test case (TestID-5.1.5) to ensure deterministic testing, recommending a single expected behavior and using a deviation if implementations differ.