P4RT ACL and gRIBI interaction

[rohit-rp]

System Test Plan see for more info: b/540866108

• Objective: Ensure predictable behavior when a packet might be matched by both a P4RT-programmed table entry (e.g., an ACL) and a gRIBI-programmed route.
  • Interfaces Used: P4RT, gRIBI, gNMI
  • Expected Outcome Summary:
    • The test verifies the actual packet treatment matches the expected vendor-documented pipeline order (e.g., ACLs before L3 lookup).
    • The interaction is consistent and does not cause instability.

[OpenConfigBot]

Pull Request Functional Test Report for #5987 / b8f312a

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	34929219	Log
Cisco 8000E		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	0a1df46c	Log
Cisco XRd		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	0b95ee73	Log
Juniper ncPTX		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	e6f40fc9	Log
Nokia SR Linux		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	905df0b4	Log
Openconfig Lemming		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding	53a953a0	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding
Cisco		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding
Juniper		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding
Nokia		TE-1.3: P4RT ACL Interaction with gRIBI Forwarding

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new system test plan designed to validate the data plane behavior when packets are subject to both P4RT ACLs and gRIBI routes. The primary goal is to ensure that the packet treatment adheres to expected pipeline precedence and maintains system stability during concurrent programming of these two control plane protocols.

Highlights

• New Test Case Added: Introduced a new system test (TE-1.3) to verify the interaction between P4RT-programmed ACLs and gRIBI-programmed routes.
• Test Documentation: Added a comprehensive README detailing the test procedure, environment setup, and validation criteria for P4RT and gRIBI interaction.
• Registry Update: Registered the new test case in the testregistry.textproto file to include it in the test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new test plan, TE-1.3, to verify the interaction between P4RT ACLs and gRIBI forwarding. Feedback on the changes includes correcting style guide violations regarding the use of private IPv4 addresses (10.0.0.0/8) in the test documentation, replacing a placeholder for the required DUT platform, and reverting manual edits to the auto-generated testregistry.textproto file in favor of using the registry synchronization script.