Adding gRIBI recursive route resolution with routing protocol churn

[rohit-rp]

System Test Plan see for more info: b/540866644

• Objective: Verify that gRIBI routes resolving recursively via BGP/ISIS correctly update their forwarding state when the underlying BGP/ISIS routes flap (route withdrawal and re-advertisement) without session loss.
  • Interfaces Used: gRIBI, BGP/ISIS,
  • Expected Outcome Summary:
    • gRIBI programs a route that recursively resolves via a BGP prefix.
    • We then flap the BGP prefix (withdraw and re-advertise different next-hops).
    • We expect the device to dynamically update the gRIBI route's hardware forwarding state to follow the new BGP next-hops.
    • Traffic should resume forwarding to the new path after convergence.
  • Success Metrics:
    • Recursive Update Accuracy: Traffic is correctly steered to the new BGP next-hop after the flap.
    • State Convergence: The time to reprogram the recursive next-hop in hardware is within required limits.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new system test case designed to validate the robustness of gRIBI recursive route resolution. The test specifically ensures that forwarding states are correctly updated when underlying BGP routes undergo withdrawal and re-advertisement, confirming that the system can handle routing protocol churn without requiring manual gRIBI reprovisioning.

Highlights

• New Test Case Added: Introduced a new system test (TE-1.4) to verify gRIBI recursive route resolution under BGP protocol churn.
• Test Documentation: Added a comprehensive README detailing the test environment, procedure, and expected outcomes for recursive route resolution.
• Registry Update: Registered the new test case in the test registry to ensure it is tracked and discoverable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5991 / 4260c07

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	62629ec3	Log
Cisco 8000E		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	0db6ecdb	Log
Cisco XRd		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	84495e4d	Log
Juniper ncPTX		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	0f3c996d	Log
Nokia SR Linux		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	fc67c32c	Log
Openconfig Lemming		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn	c3940d17	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn
Cisco		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn
Juniper		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn
Nokia		TE-1.4: gRIBI Recursive Route Resolution under Routing Protocol Churn

Help

[gemini-code-assist]

Code Review

This pull request introduces a new test plan, TE-1.4, for verifying gRIBI recursive route resolution under routing protocol churn. It includes the test documentation, metadata, and registration in the test registry. The reviewer feedback correctly identifies multiple violations of the repository's style guide regarding IPv4 address assignments, specifically the use of unauthorized private ranges like 10.0.0.0/24 and 20.0.0.0/24. These should be updated to compliant ranges such as 100.64.0.0/24 and 198.18.0.0/24 as suggested.

[AmrNJ]

LGTM.