Skip to content

Add covered subinterface state paths to system_generic_health_check README.md - #6000

Merged
AmrNJ merged 2 commits into
openconfig:mainfrom
singhavnish2516:subinterface-state-paths-readme
Sep 8, 2026
Merged

Add covered subinterface state paths to system_generic_health_check README.md#6000
AmrNJ merged 2 commits into
openconfig:mainfrom
singhavnish2516:subinterface-state-paths-readme

Conversation

@singhavnish2516

Copy link
Copy Markdown
Contributor

Update the OpenConfig Path Coverage section in system_generic_health_check/README.md to document subinterface state paths that are already verified in TestInterfacesubIntfs (system_generic_health_check_test.go).

OpenConfig paths covered:

  • /interfaces/interface/subinterfaces/subinterface/state/counters/out-octets
  • /interfaces/interface/subinterfaces/subinterface/state/admin-status
  • /interfaces/interface/subinterfaces/subinterface/state/description

…EADME.md

OpenConfig paths covered:
- /interfaces/interface/subinterfaces/subinterface/state/counters/out-octets
- /interfaces/interface/subinterfaces/subinterface/state/admin-status
- /interfaces/interface/subinterfaces/subinterface/state/description
@singhavnish2516
singhavnish2516 requested a review from a team as a code owner September 8, 2026 11:19
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the documentation for the system_generic_health_check utility by explicitly listing subinterface state paths that are currently covered by existing tests. This ensures that the README accurately reflects the current test coverage for OpenConfig paths.

Highlights

  • Documentation Update: Updated the OpenConfig Path Coverage section in the system_generic_health_check README.md file.
  • Path Coverage Clarification: Added three specific subinterface state paths to the documentation that are already verified in the corresponding test suite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Sep 8, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #6000 / 52df4a6

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
Health-1.1: Generic Health Check
cfc10b77 Log
Cisco 8000E status
Health-1.1: Generic Health Check
615b8122 Log
Cisco XRd status
Health-1.1: Generic Health Check
51ddef52 Log
Juniper ncPTX status
Health-1.1: Generic Health Check
1840ec92 Log
Nokia SR Linux status
Health-1.1: Generic Health Check
13579b8f Log
Openconfig Lemming status
Health-1.1: Generic Health Check
68cbd536 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista status
Health-1.1: Generic Health Check
Cisco status
Health-1.1: Generic Health Check
Juniper status
Health-1.1: Generic Health Check
Nokia status
Health-1.1: Generic Health Check

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the system generic health check test by adding three subinterface state paths (out-octets, admin-status, and description) to the list of monitored paths. There are no review comments, and I have no feedback to provide.

@AmrNJ AmrNJ self-assigned this Sep 8, 2026
@AmrNJ
AmrNJ merged commit 2b82041 into openconfig:main Sep 8, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants