Skip to content

Added UDP IPV4 Encapsulation Header as per requirement - #285

Merged
robshakir merged 3 commits into
openconfig:mainfrom
keysightgems:update_udpv4_encap
Sep 8, 2026
Merged

Added UDP IPV4 Encapsulation Header as per requirement#285
robshakir merged 3 commits into
openconfig:mainfrom
keysightgems:update_udpv4_encap

Conversation

@keysightgems

Copy link
Copy Markdown
Contributor

The changes were required based on the README/PR below, so I added the IPv4 UDP encapsulation header code accordingly. Please review and merge the changes.

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/gribi/mpls_in_udp/otg_tests/mpls_in_udp_scale/README.md
Raised PR for the Readme: openconfig/featureprofiles#5714

@robshakir robshakir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

Please can you also add a test into fluent_test.go's TestEntry table-driven test that validates that this functionality works as expected within an entry?

Comment thread fluent/fluent.go
Comment thread fluent/fluent.go Outdated
@keysightgems

Copy link
Copy Markdown
Contributor Author

Thanks for the change.

Please can you also add a test into fluent_test.go's TestEntry table-driven test that validates that this functionality works as expected within an entry?

Addressed all the comments, validated the changes, and committed the code.

ixia@ubserver-2-2404:~/Phase2/Giribigo/gribigo-copy$ go test ./fluent/ -run TestEntry -v
=== RUN TestEntry
=== RUN TestEntry/prefix_populated_only
=== RUN TestEntry/prefix,_nhg,_ni
=== RUN TestEntry/next-hop-group
=== RUN TestEntry/next-hop
=== RUN TestEntry/next-hop_interface_only
=== RUN TestEntry/nhg_with_a_backup
=== RUN TestEntry/next-hop_with_decap
=== RUN TestEntry/mpls_entry
=== RUN TestEntry/ipv6_entry
=== RUN TestEntry/next-hop_mpls-over-udpv6
=== RUN TestEntry/next-hop_mpls-over-udpv4
--- PASS: TestEntry (0.02s)
--- PASS: TestEntry/prefix_populated_only (0.00s)
--- PASS: TestEntry/prefix,_nhg,_ni (0.00s)
--- PASS: TestEntry/next-hop-group (0.00s)
--- PASS: TestEntry/next-hop (0.00s)
--- PASS: TestEntry/next-hop_interface_only (0.00s)
--- PASS: TestEntry/nhg_with_a_backup (0.00s)
--- PASS: TestEntry/next-hop_with_decap (0.00s)
--- PASS: TestEntry/mpls_entry (0.00s)
--- PASS: TestEntry/ipv6_entry (0.00s)
--- PASS: TestEntry/next-hop_mpls-over-udpv6 (0.00s)
--- PASS: TestEntry/next-hop_mpls-over-udpv4 (0.00s)
PASS
ok github.com/openconfig/gribigo/fluent 0.258s

@keysightgems
keysightgems requested a review from robshakir August 31, 2026 09:41
Comment thread fluent/fluent.go
@robshakir
robshakir merged commit 5bb8a9e into openconfig:main Sep 8, 2026
12 checks passed
@keysightgems

keysightgems commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@robshakir

Thanks for merging the PR.
Can you please create a new version of gribigo to get the changes to FP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants