Enable Lucius libsai.so builds using bazel - #716
Merged
Conversation
royyi8
force-pushed
the
bazel_libsai_build
branch
from
August 24, 2026 23:45
7722631 to
06bc065
Compare
Contributor
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
royyi8
force-pushed
the
bazel_libsai_build
branch
from
August 25, 2026 20:45
fac33a5 to
63791ab
Compare
Contributor
|
/gcbrun |
royyi8
force-pushed
the
bazel_libsai_build
branch
from
August 25, 2026 21:34
63791ab to
191fcb6
Compare
Contributor
|
/gcbrun |
Change-Id: Ic3e6d6eb2ea6d1d894b77f26326835b5581c9a5e
Change-Id: I33f07788ad0f91dfb7fa6e2da86641028a39f3cb
royyi8
force-pushed
the
bazel_libsai_build
branch
from
August 26, 2026 01:16
191fcb6 to
4022dd5
Compare
Contributor
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
Change-Id: I3e98b46e01d7f2e51802ab99c3fe5af5b9f13597
royyi8
force-pushed
the
bazel_libsai_build
branch
from
August 27, 2026 23:28
6f4daa9 to
3fdfa99
Compare
Contributor
|
/gcbrun |
Contributor
|
Thanks for this update of Lucius SAI, I have a few questions:
|
sonikajindal
approved these changes
Aug 28, 2026
Contributor
Author
2 & 3. This block is from the top level MODULE.bazel: We use open source SAI 1.15 and apply sai.patch. This is the same approach as we do currently except we compile Lucius libsai.so using bazel rather than using makefile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.