Add route lookup ingress drop counter to interface and subinterface counters - #1529
Add route lookup ingress drop counter to interface and subinterface counters#1529ostromart wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-interfaces YANG module to version 3.11.0, introducing a new 'in-route-lookup-drop' counter leaf. The review feedback highlights two main issues: first, a revision entry for version 3.9.0 is added but the corresponding 'ingress low-TTL discard counter' is missing from the code changes; second, the description for the 3.11.0 revision should be updated to clarify that the new counter applies to both interface and subinterface counters.
05b4ac6 to
299e2cd
Compare
|
This PR is intended to merge after #1528 and the version reflects that. |
…ounters This change introduces a new operational state counter in-route-lookup-drop under common interface counters (/interfaces/interface/state/counters/in-route-lookup-drop and /interfaces/interface/subinterfaces/subinterface/state/counters/in-route-lookup-drop) to track inbound packets dropped during routing lookup due to no matching route entry in the forwarding table (LPM miss) or matching an explicit drop route. The version has been bumped to 3.11.0 in openconfig-interfaces.yang. Change-Id: If395e99e2a65ce8e111aef5510c463249c3e7f85
299e2cd to
17df1d3
Compare
|
OC operators review August 11th: |
|
A few general comments/doubts:
|
|
To add to Ebben's comment. XR doesn't track no route drops on a per interface basis (e.g., the referenced show ip traffic command has no per interface filter), so please can you correct the references in the PR because otherwise they are misleading to those reviewing or considering the PR. We do have per device and per node level versions of these counters, and we would also be able to provide them on a per ASIC basis, but not at a higher granularity today. |
|
OC operator review Sept1 2026. @ostromart requesting you to share your responses so that we can move ahead |
|
|
OC operators review September 8th. @ostromart has updated the Cisco reference, and there are some notes w.r.t NVIDIA implementation which he will add to the PR. along with the description update to the new references. @rgwilton / @earies kindly take a look. Regarding SAI and its implications to new open config paths that are not yet supported, we will take it up in the community meeting and decide the way forward. |
This change introduces a new operational state counter
in-route-lookup-dropunder common interface counters (/interfaces/interface/state/counters/in-route-lookup-dropand/interfaces/interface/subinterfaces/subinterface/state/counters/in-route-lookup-drop) to track inbound packets dropped during routing table lookup. This could be due to no matching route entry in the forwarding table (LPM miss) or matching an explicit drop route.The version has been bumped to
3.11.0inopenconfig-interfaces.yang.Change-Id: I2f1a6c4290871e86b3e94a815a1e2f89104b28cd
Change Scope
in-route-lookup-droptoopenconfig-interfaces.yang(underinterface-common-counters-state) to count inbound packets discarded on a routed interface or subinterface when a routing table lookup fails to find a matching route entry (LPM miss) or encounters an explicit drop/blackhole route.interface-common-counters-stategrouping.Use case
In routed fabrics (such as spine-leaf or multi-tenant networks), silent packet discards due to routing table misses or blackhole routes are difficult to isolate using generic discard counters (
in-discards). Providing an explicit counter for route lookup drops (in-route-lookup-drop) enables network operations and automated failure pinpointing tools to immediately identify routing blackholes, unassigned IP prefix drops, or route table sync issues at both interface and subinterface granularity.Platform Implementations
SAI_IN_DROP_REASON_LPM_MISS/SAI_IN_DROP_REASON_LPM_DROP(SAI Debug Counters Proposal).in-no-routes)** Exposes routing drop statistics (show ip trafficno route discards).SWITCH_INGRESS_DROPSwith drop reasonSAI_IN_DROP_REASON_LPM4_MISSandSAI_IN_DROP_REASON_LPM6_MISS.Tree View
module: openconfig-interfaces +--rw interfaces +--rw interface* [name] ... +--ro state | +--ro counters | +--ro out-discards? oc-yang:counter64 | +--ro out-errors? oc-yang:counter64 | +--ro last-clear? oc-types:timeticks64 + | +--ro in-route-lookup-drop? oc-yang:counter64 ... +--rw subinterfaces +--rw subinterface* [index] ... +--ro state +--ro counters +--ro out-discards? oc-yang:counter64 +--ro out-errors? oc-yang:counter64 +--ro last-clear? oc-types:timeticks64 + +--ro in-route-lookup-drop? oc-yang:counter64