Add tag and track-id to static route next-hop attributes - #1536
Add tag and track-id to static route next-hop attributes#1536Verma-Anukul wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-local-routing.yang model to version 4.2.0, introducing tag and track-id leaves to the local-common-route-attributes grouping. Feedback highlights a design issue where these next-hop-specific attributes are incorrectly exposed under aggregate routes. It is recommended to move these leaves to a next-hop-specific grouping and to use oc-pt:tag-type for the tag leaf instead of a raw uint32 for consistency across OpenConfig models.
408f92d to
bf012c2
Compare
Add tag (oc-pt:tag-type) and track-id leaves to local-static-nexthop-config for static route next-hop config and state. Leaves are scoped to next-hops only and are not exposed on local aggregate routes. Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
bf012c2 to
d22bdfa
Compare
|
@dplore |
akalluru1
left a comment
There was a problem hiding this comment.
the PR description says track-id leaf is present under local-aggregates/aggregate path but I don't seem to find it in the public repo. Is there some outstanding PR introducing this leaf in the above YANG path?
| "Identifier of a reachability track object associated with this | ||
| nexthop. The static route nexthop is eligible for installation | ||
| only while the referenced track object reports an 'up' state. | ||
| The track object is defined separately (e.g., IP SLA, NQA, |
There was a problem hiding this comment.
Is there a separate OC model for track object definition? If so, Let's please use leafref.
|
please remove this reference for track id, it's not a refernce to EOS Arista EOS (Ansible): eos_static_routes — track parameter |
Add per-nexthop tag and track-id leaves to the
local-common-route-attributes grouping used by static route next-hop config and state.
Change Scope
This change adds two optional leaves to the
local-common-route-attributesgrouping inopenconfig-local-routing.yang:tag(uint32, range1..4294967295) — per-nexthop administrative tag for route-map matching, redistribution filtering, and BGP export control. It does not affect route preference or nexthop selection.track-id(string) — identifier of a reachability track object (e.g., IP SLA, NQA, RPM, active probe). The nexthop is eligible for installation only while the referenced track object reports anupstate.These leaves appear on static route next-hop config and state via existing
uses local-static-nexthop-config→uses local-common-route-attributes. They also appear on local aggregate config/state, which reuses the same grouping.Backwards compatibility: Yes. Both leaves are optional additions with no changes to existing leaves or keys.
Platform Implementations
Route tag
Track Id
Tree View
Relevant portion of
openconfig-network-instancetree underprotocols/protocol/static-routes/static/next-hops/next-hop:module: openconfig-network-instance +--rw network-instances +--rw network-instance* [name] +--rw protocols +--rw protocol* [identifier name] +--rw static-routes +--rw static* [prefix] +--rw next-hops +--rw next-hop* [index] +--rw config | +--rw index? string | +--rw next-hop? union | +--rw recurse? boolean | +--rw metric? uint32 | +--rw preference? uint32 | +--rw wecmp-weight? union + | +--rw tag? uint32 + | +--rw track-id? string +--ro state | +--ro index? string | +--ro next-hop? union | +--ro recurse? boolean | +--ro metric? uint32 | +--ro preference? uint32 | +--ro wecmp-weight? union + | +--ro tag? uint32 + | +--ro track-id? string +--rw enable-bfd +--rw interface-refNote: The same
tagandtrack-idleaves also appear underlocal-aggregates/aggregate/{config,state}because that container reuseslocal-common-route-attributes.