anchor the whole YANG pattern in fixYangRegexp - #1096
Open
nabhan06 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixYangRegexp only wraps the converted pattern in parens when the YANG pattern does not already start with a caret, so
^ab|cd$is passed to the regexp package unchanged and evaluated as(^ab)|(cd$). Since YANG patterns are implicitly anchored to the whole string, ValidateStringRestrictions then accepts values the schema forbids, e.g. "abcdef" for a leaf restricted to^ab|cd$.The same first/last character inspection also treats an escaped trailing dollar as an anchor: a pattern like
[0-9]+\$becomes^([0-9]+\)$, which does not compile, so every value for that leaf fails validation with a regexp parse error.This strips whatever anchors the pattern already carries (a trailing
$counts as an anchor only when it is unescaped) and then always wraps the remainder in^(...)$. Existing expectations for^abcand^abc$change to^(abc)$, which is equivalent.